New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tsv-uniq: Remove unnecessary memory allocation #234

Merged

jondegenhardt merged 3 commits into eBay:master from jondegenhardt:tsv-uniq-use-appender

Oct 14, 2019

Contributor

jondegenhardt commented Oct 13, 2019

Three changes to reduce memory allocation and copying. Two cases involve creating a reusable buffer with appenders:

For single field keys, use the single field directly. Don't allocate or copy memory.
For multi-field keys, assemble the key in a reusable buffer.
For case-insensitive keys, assemble the lower-cased key in a reusable buffer.

jondegenhardt added 3 commits

October 13, 2019 11:09


          tsv-uniq: avoid unnecessary memory allocation.

a77993e


          tsv-uniq: avoid unnecessary memory allocation for case insensitive co…

6605d8e

…mpares.


          tsv-utils: More unit tests for different key sizes and case sensitivity.

99bc809

jondegenhardt merged commit 45ab9d5 into eBay:master

jondegenhardt deleted the tsv-uniq-use-appender branch

October 14, 2019 00:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet